Open
Conversation
Signed-off-by: Weida Hong <wdhongtw@google.com>
yuyanpeng-google
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
torch_viewandjax_view, expose a<func>_elemvariant that easier for user code to leverage typing analysis.torch_viewandjax_vieware super powerful, but also quite hard to annotate it's function signature, as they support arbitrary tree structure. Users need to manuallytyping.castin order to this powerful interface, while still have the type being inferenced.In this PR, we try to expose another interface, that's less powerful, but friendlier for typing system.
As long as all the input given with their types, the computation results can all have correct types.
Typing analysis can works properly in this case. Also, IDE can provide more help for developer, e.g. method auto-complete, jump-to-definition ... etc.